From 22ddb71603b797b33152b004dad96a1eb3a6e79d Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Thu, 6 Jul 2023 17:56:40 +0200 Subject: [PATCH 1/2] declare unused var with _ and always name event the same --- main.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/main.go b/main.go index f7c2b2d..d4a04c3 100644 --- a/main.go +++ b/main.go @@ -393,7 +393,7 @@ func main() { gtk.MainQuit() }) - win.Connect("key-release-event", func(window *gtk.Window, event *gdk.Event) bool { + win.Connect("key-release-event", func(_ *gtk.Window, event *gdk.Event) bool { key := &gdk.EventKey{Event: event} if key.KeyVal() == gdk.KEY_Escape { s, _ := searchEntry.GetText() @@ -412,7 +412,7 @@ func main() { return false }) - win.Connect("key-press-event", func(window *gtk.Window, event *gdk.Event) bool { + win.Connect("key-press-event", func(_ *gtk.Window, event *gdk.Event) bool { key := &gdk.EventKey{Event: event} switch key.KeyVal() { case gdk.KEY_downarrow, gdk.KEY_Up, gdk.KEY_Down, gdk.KEY_Left, gdk.KEY_Right, gdk.KEY_Tab, @@ -467,8 +467,8 @@ func main() { resultWindow.SetEvents(int(gdk.ALL_EVENTS_MASK)) resultWindow.SetPolicy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC) - resultWindow.Connect("button-release-event", func(sw *gtk.ScrolledWindow, e *gdk.Event) bool { - btnEvent := gdk.EventButtonNewFromEvent(e) + resultWindow.Connect("button-release-event", func(_ *gtk.ScrolledWindow, event *gdk.Event) bool { + btnEvent := gdk.EventButtonNewFromEvent(event) if btnEvent.Button() == 3 { if !*resident { gtk.MainQuit() From 7a6ae82a75508b375675196c5ef93eb4dff9eb90 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Thu, 6 Jul 2023 18:02:51 +0200 Subject: [PATCH 2/2] log the unknown signal --- main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/main.go b/main.go index d4a04c3..426d138 100644 --- a/main.go +++ b/main.go @@ -180,7 +180,7 @@ func main() { gtk.MainQuit() } default: - log.Info("Unknown signal") + log.Infof("Unknown signal: %s", s.String()) } } }()